15 Feb 2018 at 17:07 #17736
Receptar obtains a very impressive score of 99%. But:
Date and time implementation : Use of date_i18n()
At least one hard coded date was found in the file site-info.php. Function get_option( ‘date_format’ ) should be used instead.15 Feb 2018 at 19:32 #17737
Thanks for checking the theme with ThemeCheck.org :) I can assure you that is no issue at all. Or do you find it any wrong?
date_i18n()is used in the theme to allow for easier dynamic year in theme footer credits area. This can not be done using
get_option( ‘date_format’ )as you might understand. Besides, the theme uses the later where appropriate.
The thing is that ThemeCheck.org have not updated their checking algorithms according to WordPress for quite some time. I have already created some issue tickets for ThemeCheck to update (way back in 2016…), but I have never gotten back any answer from them, which is pity. So, unfortunately, ThemeCheck.org starts to be a bit obsolete for me unless they update their algorithm.
They should use the latest version of https://wordpress.org/plugins/theme-check/ to check the themes. So, go ahead, download the plugin and test the theme with it to see it passes 100%.
A tip: Please always check the “issues” similar testers/checker throws, as the issue might not be relevant as in this example.
WebMan Design15 Feb 2018 at 19:42 #17738
You can actually see ThemeCheck.org throwing issues for WordPress default themes too. And those themes are always used as reference for good practices and coding standards in WordPress.
If you preview the score for Twenty Seventeen theme you will see the warning #1 is actually related to ThemeCheck.org outdated algorithm and the other issues #2, #3 and #4 are actually not issues at all, just recommendations. They differ from theme to theme depending on the theme features.
And ThemeCheck.org knows this, and that’s why any score of 95 and above is considered as passing WordPress requirements (they apply green color on it).
WebMan Design16 Feb 2018 at 11:01 #17739
Hi Oliver Juhas,
Good to know! Thank you for the explanation!
You must be logged in to reply to this topic.